Conversation
stefanpenner
force-pushed
the
cleanup
branch
10 times, most recently
from
9a65285 to
47837d6
Compare
Member
|
I see a lot of conflicts with #13549 ahead of me... 😄 |
stefanpenner
force-pushed
the
cleanup
branch
8 times, most recently
from
cfd7094 to
95369f0
Compare
Member
Author
I can rebase that for you once this lands |
Member
|
don't worry, I can take it 😉 |
Member
|
I'd appreciate an r+ on emberjs/emberjs-build#163 though |
This was referenced Jun 15, 2016
This was referenced Jun 15, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can gladly split this up by file, or by module or by folder or leave it as is. Open to recommendations.
=>were appropriate