ESLint by Turbo87 · Pull Request #13549 · emberjs/ember.js

Turbo87 · 2016-05-23T23:40:29Z

This PR adds ESLint code checking. JSHint/JSCS are not removed yet and ESLint is only part of the mocha test suite so far until emberjs-build supports ESLint too. Most of the JSHint/JSCS rule equivalents have been enabled and only two of the custom JSCS rules are missing at the moment and need to be reimplemented on the ESLint API.

partly resolves #13006

port require-comments-to-include-access rule
port disallow-const-outside-module-scope rule

/cc @stefanpenner @rwjblue

homu · 2016-05-24T13:00:22Z

☔ The latest upstream changes (presumably #13542) made this pull request unmergeable. Please resolve the merge conflicts.

Turbo87 · 2016-05-24T14:47:12Z

All JSHint/JSCS equivalents have been ported and/or enabled now! 🎉

Turbo87 · 2016-05-24T21:09:49Z

looks like I'm being bitten by the node_modules caching on TravisCI... :-/

Turbo87 · 2016-05-25T14:54:41Z

I've extracted the custom ESLint rules into https://github.com/Turbo87/eslint-plugin-ember-internal to avoid the subproject issues that caused the previous CI failures

homu · 2016-05-25T19:21:24Z

☔ The latest upstream changes (presumably b8c5e08) made this pull request unmergeable. Please resolve the merge conflicts.

rwjblue · 2016-05-26T01:25:00Z

Why are there so many file changes here? I believe that we should be applying the existing rules only...

Turbo87 · 2016-05-26T05:50:16Z

@rwjblue except for the last commit: because JSHint apparently isn't that great at catching these things. It's been the same in all the other repos I've converted so far. ESLint usually found a lot more issues than JSHint.

homu · 2016-05-26T08:08:17Z

☔ The latest upstream changes (presumably ee55266) made this pull request unmergeable. Please resolve the merge conflicts.

stefanpenner · 2016-06-03T15:04:38Z

packages/ember-glimmer/tests/integration/helpers/closure-action-test.js

is this still WIP?

The issue here was that outerComponent was unused. I wasn't sure if it was actually supposed to be used in a test somewhere so I commented it out for now. Let me know if I should remove is completely.

If the tests pass without it, just delete it. We can always get it back if needed 😸

stefanpenner · 2016-06-03T15:05:52Z

I'm 👍 on this, all changes look good. I did point out some what appears to be WIP

rwjblue · 2016-06-03T15:13:07Z

Please squash

rwjblue · 2016-06-03T15:15:48Z

ESLint is only part of the mocha test suite so far until emberjs-build supports ESLint too

This must be fixed before landing. The linting failures need to be included in the normal ember test --server output (just like in an ember-cli app).

Turbo87 · 2016-06-03T15:28:17Z

@rwjblue @stefanpenner would love to get some feedback on emberjs/emberjs-build#161, then I'll start working on integrating ESLint into ember test --server.

homu · 2016-06-04T12:40:33Z

☔ The latest upstream changes (presumably #13553) made this pull request unmergeable. Please resolve the merge conflicts.

homu · 2016-07-01T19:49:29Z

☔ The latest upstream changes (presumably #13775) made this pull request unmergeable. Please resolve the merge conflicts.

homu · 2016-07-19T13:43:14Z

☔ The latest upstream changes (presumably #13838) made this pull request unmergeable. Please resolve the merge conflicts.

homu · 2016-11-30T16:09:27Z

☔ The latest upstream changes (presumably #14658) made this pull request unmergeable. Please resolve the merge conflicts.

homu · 2017-01-03T17:14:45Z

☔ The latest upstream changes (presumably #14776) made this pull request unmergeable. Please resolve the merge conflicts.

Turbo87 · 2017-01-04T07:59:52Z

@rwjblue rebased and updated emberjs-build to v0.19.0

rwjblue · 2017-01-04T12:02:25Z

Restarted travis build (was failing bizarrely)

Turbo87 · 2017-01-04T12:54:45Z

@rwjblue failure might be related to the fact that I didn't update the yarn lockfile

(and I still believe that it's stupid that it's failing because of that...)

see http://eslint.org/docs/rules/no-unsafe-finally

Turbo87 · 2017-01-04T13:17:45Z

🍏

rwjblue · 2017-01-04T13:48:40Z

Thanks for working so hard on this!

Turbo87 force-pushed the eslint branch 2 times, most recently from bf4133a to ca20f1a Compare May 24, 2016 14:24

Turbo87 force-pushed the eslint branch from 5424847 to 225d6cd Compare May 24, 2016 21:01

Turbo87 force-pushed the eslint branch 2 times, most recently from aefce60 to 3343e3b Compare May 25, 2016 14:54

Turbo87 force-pushed the eslint branch from bdb64f2 to adac85e Compare May 25, 2016 16:18

Turbo87 force-pushed the eslint branch 2 times, most recently from eafe29f to 4b0d84d Compare May 25, 2016 21:39

Turbo87 force-pushed the eslint branch from 4b0d84d to 6f89e50 Compare May 27, 2016 07:33

Turbo87 mentioned this pull request May 28, 2016

ESLint checking for Ember.js emberjs/emberjs-build#161

Closed

stefanpenner reviewed Jun 3, 2016
View reviewed changes

Turbo87 mentioned this pull request Jun 5, 2016

Replace JSHint/JSCS with ESLint emberjs/emberjs-build#163

Merged

Turbo87 mentioned this pull request Jun 13, 2016

spring cleaning #13658

Merged

Turbo87 force-pushed the eslint branch from 6f89e50 to e66adcf Compare July 1, 2016 13:01

Turbo87 force-pushed the eslint branch 2 times, most recently from 2134c2c to 6aea607 Compare July 1, 2016 20:39

Turbo87 mentioned this pull request Nov 11, 2016

Code cleanup based on ESLint warnings #14603

Merged

Turbo87 force-pushed the eslint branch from 6aea607 to 681aa65 Compare November 17, 2016 18:21

Turbo87 force-pushed the eslint branch from 681aa65 to f8f080c Compare December 8, 2016 17:47

Turbo87 added 2 commits January 4, 2017 08:39

Add ESLint config files

b0054a0

Port custom JSCS rules to ESLint

3534ab3

Turbo87 force-pushed the eslint branch from 4cd16c1 to 14cbee5 Compare January 4, 2017 07:58

Turbo87 force-pushed the eslint branch from 14cbee5 to ac892e3 Compare January 4, 2017 12:54

Turbo87 added 3 commits January 4, 2017 13:59

Update "emberjs-build" to v0.19.0

7bb6ec6

ember-cli-build: Set "eslintRulePaths" for "emberjs-build"

7b6aea7

ember-metal/instrumentation: Move "return" out of "finally" block

406b0cf

see http://eslint.org/docs/rules/no-unsafe-finally

Turbo87 force-pushed the eslint branch from ac892e3 to 406b0cf Compare January 4, 2017 12:59

rwjblue merged commit 1737044 into emberjs:master Jan 4, 2017

homu mentioned this pull request Jan 4, 2017

Integrate Glimmer Macros For Binary VM #14781

Merged

Turbo87 deleted the eslint branch January 4, 2017 14:16

Uh oh!

Conversation

Turbo87 commented May 23, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

homu commented May 24, 2016

Uh oh!

Turbo87 commented May 24, 2016

Uh oh!

Turbo87 commented May 24, 2016

Uh oh!

Turbo87 commented May 25, 2016

Uh oh!

homu commented May 25, 2016

Uh oh!

rwjblue commented May 26, 2016

Uh oh!

Turbo87 commented May 26, 2016

Uh oh!

homu commented May 26, 2016

Uh oh!

stefanpenner Jun 3, 2016

Choose a reason for hiding this comment

Uh oh!

Turbo87 Jun 3, 2016

Choose a reason for hiding this comment

Uh oh!

rwjblue Jun 3, 2016

Choose a reason for hiding this comment

Uh oh!

stefanpenner commented Jun 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rwjblue commented Jun 3, 2016

Uh oh!

rwjblue commented Jun 3, 2016

Uh oh!

Turbo87 commented Jun 3, 2016

Uh oh!

homu commented Jun 4, 2016

Uh oh!

homu commented Jul 1, 2016

Uh oh!

homu commented Jul 19, 2016

Uh oh!

homu commented Nov 30, 2016

Uh oh!

homu commented Jan 3, 2017

Uh oh!

Turbo87 commented Jan 4, 2017

Uh oh!

rwjblue commented Jan 4, 2017

Uh oh!

Turbo87 commented Jan 4, 2017

Uh oh!

Turbo87 commented Jan 4, 2017

Uh oh!

rwjblue commented Jan 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Turbo87 commented May 23, 2016 •

edited

Loading

stefanpenner commented Jun 3, 2016 •

edited

Loading