Skip to content

[Glimmer2/Cleanup] Remove tests related to private View APIs#13838

Merged
rwjblue merged 1 commit intoemberjs:masterfrom
chadhietala:cleanup-views
Jul 19, 2016
Merged

[Glimmer2/Cleanup] Remove tests related to private View APIs#13838
rwjblue merged 1 commit intoemberjs:masterfrom
chadhietala:cleanup-views

Conversation

@chadhietala
Copy link
Contributor

No description provided.


import { test, testModule } from 'internal-test-helpers/tests/skip-if-glimmer';

QUnit.module('views/view/view_lifecycle_test - pre-render', {
Copy link
Contributor Author

@chadhietala chadhietala Jul 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krisselden @rwjblue @wycats Need confirmation that this thing can just go away. From what I can tell it's testing cases that do not make sense in the post-view era.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to remove to me.

@chadhietala chadhietala changed the title [GLimmer2/Cleanup] Remove tests related to private View APIs [Glimmer2/Cleanup] Remove tests related to private View APIs Jul 18, 2016
@rwjblue rwjblue merged commit 46a8721 into emberjs:master Jul 19, 2016
@homu homu mentioned this pull request Jul 19, 2016
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants