Code cleanup based on ESLint warnings#14603
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Nov 12, 2016
Merged
Conversation
rwjblue
requested changes
Nov 11, 2016
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Looks good, happy to land independently.
Can you fixup the two issues that JSCS caught, and squash the commits?
| this.registerComponent('some-clicky-thing', { | ||
| ComponentClass: Component.extend({ | ||
| tagName: 'button', | ||
| classNames: ['foo', 'bar'], |
Member
There was a problem hiding this comment.
Need to remove this trailing comma
| this.registerComponent('some-clicky-thing', { | ||
| ComponentClass: Component.extend({ | ||
| concatenatedProperties: ['blahzz'], | ||
| blahzz: ['blark', 'pory'], |
Member
Author
|
@rwjblue done |
Member
Author
|
also fixed the failing JSHint test now... Travis will hopefully agree :) |
Member
Author
|
🍏 |
rwjblue
approved these changes
Nov 11, 2016
Member
|
Still need to squash commmits though |
Member
Author
|
@rwjblue not a fan of squashing in general, but: done! |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contents in this PR were mostly extracted from #13549
/cc @rwjblue @stefanpenner