[Bugfix Beta] Fix for auto-mut wrapping of closure actions.

[rwjblue]

Given the following:

{{x-foo derp=(action 'herk')}}

{{! app/templates/components/x-foo.hbs }}

{{x-bar derp=derp}}

export default Component.extend({
  didInsertElement() {
    this.get('derp')();
  }
});

An error is triggered with the following output:

TypeError: this.attrs.derp is not a function
    at Class.fireAction (http://localhost:7200/ember-tests.js:21306:46)
    at http://localhost:7200/ember-tests.js:21344:24
    at Object.run (http://localhost:7200/ember.debug.js:294:25)
    at Object.run [as default] (http://localhost:7200/ember.debug.js:19515:27)
    at _class2.runTask (http://localhost:7200/ember-tests.js:32041:34)
    at _class2.testActionClosureDoesNotGetAutoMutWrapped [as @test action closure does not get auto-mut wrapped] (http://localhost:7200/ember-tests.js:21343:12)
    at Object.<anonymous> (http://localhost:7200/ember-tests.js:31691:31)
    at runTest (http://localhost:7200/qunit/qunit.js:843:28)
    at Object.run (http://localhost:7200/qunit/qunit.js:828:4)
    at http://localhost:7200/qunit/qunit.js:970:11

[chancancode]

Something seems fishy here, why is any new code accessing this.attrs.* o_0?

[chancancode]

Ah it's in the test, carry on

[rwjblue]

This would prevent passing a class down to a child component. Given the following setup (we should add a test for this):

{{foo-bar klass=ModelClass}}

{{! parent component }}
export default Ember.Component.extend({
  init() {
    this._super();
    this.klass = Ember.Object.extend();
  }
});

// foo-bar component

export default Ember.Component.extend({
  actions: {
    updateKlass(newKlass) {
      this.attrs.klass.update(newKlass);
    }
  }
});

[rwjblue]

In prior versions (1.13 - 2.8) we use a symbol stamped on the generated action function that we used as an identifier that this is an action.

Assuming we do the same here (this would alleviate the concern about intentionally passing down a class / function that is intended to be two way bound), this would look something like:

if (typeof value === 'function' && value[ACTION]) {
  attrs[name] = value;
} else if (ref[UPDATE]) {
  // ...snip...
}

[chadhietala]

Fixed.