Closed
Conversation
Contributor
|
☔ The latest upstream changes (presumably #14361) made this pull request unmergeable. Please resolve the merge conflicts. |
This cleans up and unifies the handling of curly comopnent arguments. It splits the work into two distinct phases - gatherArgs assembles an EvaluatedArgs that combines all variations of positional and named arguments into a single EvaluatedArgs object - ComponentArgs.create takes the EvaluatedArgs and produces the curly-component specific attrs & props structures with mutable cells, etc.
This is a feature under discussion in [RFC 95](emberjs/rfcs#95), implemented behind a symbol. It allows components to access dynamically scoped variables via: ```js import { DYNAMIC_VAR_PARAMS } from 'ember-glimmer/utils/process-args'; MyComponent.reopenClass({ [ DYNAMIC_VAR_PARAMS ]: [ 'outletState' ] }) ``` I intend to use it next within the LinkComponent as part of a refactor to make link-to cleaner and faster.
ef4
force-pushed
the
dynamic-var-params
branch
from
a710ff5 to
cc9ee0a
Compare
ef4
force-pushed
the
dynamic-var-params
branch
from
cc9ee0a to
57baf73
Compare
Contributor
|
☔ The latest upstream changes (presumably #13996) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
I think that we decided not to move forward on this (and emberjs/rfcs#95 ended up sticking to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a feature under discussion in RFC 95, implemented behind a symbol.
It allows components to access dynamically scoped variables via:
I intend to use it next within the LinkComponent as part of a refactor to make link-to cleaner and faster.
This PR depends on glimmerjs/glimmer-vm#332 and #14355.