Skip to content

Run backtracking assertion only in debug mode #14856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elwayman02 wants to merge 2 commits into from
Closed

Run backtracking assertion only in debug mode #14856

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00b8b94
Run backtracking assertion only in debug mode
elwayman02 Jan 20, 2017
ef864d9
Wrap entire conditional in runInDebug
elwayman02 Jan 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/ember-metal/lib/property_events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { guidFor, symbol } from 'ember-utils';
import { runInDebug } from 'ember-metal';
import {
peekMeta
} from './meta';
Expand Down Expand Up @@ -112,10 +113,12 @@ function propertyDidChange(obj, keyName, _meta) {

markObjectAsDirty(meta, keyName);

if (isEnabled('ember-glimmer-detect-backtracking-rerender') ||
runInDebug(() => {
if (isEnabled('ember-glimmer-detect-backtracking-rerender') ||
isEnabled('ember-glimmer-allow-backtracking-rerender')) {
assertNotRendered(obj, keyName, meta);
}
assertNotRendered(obj, keyName, meta)
Copy link
Member

@rwjblue rwjblue Jan 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I dug into this a bit, and it turns out that this isn't the right fix. Specifically, in the case where ember-glimmer-allow-backtracking-rerender is enabled we have to actually call assertNotRendered or we will not trigger a rerender when we hit this backtracking. In other words, wrapping this in runInDebug does avoid an error (due to a bug in assertNotRendered) but it also breaks the ability for rerendering to happen.

I submitted #14876 to address.

}
});
}

let WILL_SEEN, DID_SEEN;
Expand Down