Skip to content

[WIP] Fix eslint issues#15070

Closed
Exelord wants to merge 7 commits intoemberjs:masterfrom
Exelord:fix-eslint
Closed

[WIP] Fix eslint issues#15070
Exelord wants to merge 7 commits intoemberjs:masterfrom
Exelord:fix-eslint

Conversation

@Exelord
Copy link
Contributor

@Exelord Exelord commented Mar 25, 2017

I turned on no-unused-vars flag and fixed project's issues.

Remaining Issues: 614/856

@rwjblue
Copy link
Member

rwjblue commented Mar 25, 2017

Does eslint --fix take care of these? It may be easier than doing them by hand...

@Exelord
Copy link
Contributor Author

Exelord commented Mar 25, 2017

Unfortunately not :/ I have to do it by hand

@homu
Copy link
Contributor

homu commented Mar 26, 2017

☔ The latest upstream changes (presumably #15043) made this pull request unmergeable. Please resolve the merge conflicts.

@homu
Copy link
Contributor

homu commented Apr 5, 2017

☔ The latest upstream changes (presumably #15091) made this pull request unmergeable. Please resolve the merge conflicts.

@locks
Copy link
Contributor

locks commented May 18, 2017

@Exelord heya :) What's the status on this effort?

@Exelord
Copy link
Contributor Author

Exelord commented May 19, 2017

Hey @locks :) I'm still working on it on. I have some problems with tests using unscoped variables and this blocked me right now. I will look at it once again when I will back from holidays.

@homu
Copy link
Contributor

homu commented Jun 5, 2017

☔ The latest upstream changes (presumably #15319) made this pull request unmergeable. Please resolve the merge conflicts.

@mmun
Copy link
Member

mmun commented Feb 21, 2018

We now error on no-unused-vars:

'no-unused-vars': 'error'

'no-unused-vars': 'error',

@mmun mmun closed this Feb 21, 2018
@Exelord Exelord deleted the fix-eslint branch February 21, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants