Decouple ember link_to_test from globals resolver#15319
Merged
mixonic merged 1 commit intoemberjs:masterfrom Jun 5, 2017
Merged
Decouple ember link_to_test from globals resolver#15319mixonic merged 1 commit intoemberjs:masterfrom
mixonic merged 1 commit intoemberjs:masterfrom
Conversation
mixonic
commented
Jun 2, 2017
| import { jQuery } from 'ember-views'; | ||
| import { compile } from 'ember-template-compiler'; | ||
| import { setTemplates, setTemplate } from 'ember-glimmer'; | ||
| import { EMBER_IMPROVED_INSTRUMENTATION } from 'ember-debug'; |
Member
Author
There was a problem hiding this comment.
Pretty sure this is just wrong, and the tests in this file controlled by this value were not running.
mixonic
commented
Jun 2, 2017
| return run(applicationInstance, 'visit', url, options); | ||
| } else { | ||
| return run(this.application, 'visit', url, options).then(instance => { | ||
| this.applicationInstance = instance; |
Member
Author
There was a problem hiding this comment.
b/c this .then is not inside the runloop, this.applicationInstance was being assigned after this.visit('/foo'). The more predictable behavior is to wrap the then in a runloop so we can presume the instance is set on the next line of code after this.visit
mixonic
force-pushed
the
link_to_test
branch
3 times, most recently
from
c0a4379 to
7dfb4e1
Compare
mixonic
changed the title
This was referenced Jun 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #15058
It is a big one. About 30% of the way through converting the file, I'd like to finish the conversion in a single commit.