[CLEANUP beta] Remove sync runloop queue.#16097
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Jan 10, 2018
Merged
Conversation
`sync` queue was only used/present for bindings to synchronize, and Ember.Binding (along with related code) is now completely gone.
krisselden
reviewed
Jan 9, 2018
| } | ||
|
|
||
| const backburner = new Backburner(['sync', 'actions', 'destroy'], { | ||
| sync: { |
Contributor
There was a problem hiding this comment.
this functionality in backburner was only for the sync queue
Member
There was a problem hiding this comment.
ya, we can remove it from BB and then cut a major
Member
Author
There was a problem hiding this comment.
Ya, we will have to wait for a short while (because the legacy addon still needs to enable this functionality through Ember 3.4), but totally agree that it will be awesome to get rid of 😆
krisselden
approved these changes
Jan 9, 2018
stefanpenner
approved these changes
Jan 10, 2018
| } | ||
|
|
||
| const backburner = new Backburner(['sync', 'actions', 'destroy'], { | ||
| sync: { |
Member
There was a problem hiding this comment.
ya, we can remove it from BB and then cut a major
This was referenced Jan 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
syncqueue was only used/present for bindings to synchronize, and Ember.Binding (along with related code) is now completely gone.