Bring back sync queue with deprecation (until: 3.5.0).#16132
Merged
rwjblue merged 2 commits intoemberjs:masterfrom Jan 18, 2018
Merged
Bring back sync queue with deprecation (until: 3.5.0).#16132rwjblue merged 2 commits intoemberjs:masterfrom
sync queue with deprecation (until: 3.5.0).#16132rwjblue merged 2 commits intoemberjs:masterfrom
Conversation
added 2 commits
January 17, 2018 22:31
3032886 to
20d5297
Compare
|
Hi @rwjblue I don't see Ember.run.sync() in (and since) v3.0.0; Where have it gone? By the way, we have this code: The purpose is to sendAction after run.sync, to make sure that any properties depending on this 'data' have settled before we fire the change action (which may rely on 'data'). Can we change it to Everything is still "synced" before sendAction, right? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the
syncqueue was done in #16097 and #16110. Unfortunately, addon authors have reported this as a regression in the 3.0.0 beta cycle (due to it not having been previously deprecated).This reverts the removal, and adds a private API deprecation scheduled for removal in 3.5.0.