[Feature] service blueprint for module unification#16397
[Feature] service blueprint for module unification#16397mixonic merged 1 commit intoemberjs:masterfrom GavinJoyce:gj/mu-service-blueprint
Conversation
GavinJoyce
changed the title
|
|
||
| //TODO: GJ: how does this get generated? | ||
| expect(_file('app/services/foo.js')) | ||
| .to.not.exist; |
There was a problem hiding this comment.
we'll need to update https://github.com/ember-cli/ember-cli/tree/master/blueprints/addon-import to be MU aware
There was a problem hiding this comment.
even simpler: implement supportsAddon in the blueprint
There was a problem hiding this comment.
Hmm, supportsAddon doesn't currently have access to project. Another option, modify the following to exclude project.isModuleUnification:
There was a problem hiding this comment.
blueprints/service-test/index.js
Outdated
| module.exports = useTestFrameworkDetector({ | ||
| description: 'Generates a service unit test.', | ||
|
|
||
| fileMapTokens: function() { |
There was a problem hiding this comment.
You can use shorthand methods I think, since only node 4 is supported (and in 3 days, only node 6! 🎉 🎉 🎉 )
There was a problem hiding this comment.
Sadly I think its actually the end of April 😭
There was a problem hiding this comment.
crap, i thought it was the 1st 😭
blueprints/service/index.js
Outdated
| description: 'Generates a service.' | ||
| description: 'Generates a service.', | ||
|
|
||
| fileMapTokens: function() { |
GavinJoyce
changed the title
|
@rwjblue this is ready for review |
|
Looks great, thank you @GavinJoyce! |
5 participants
part of ember-cli/ember-cli#7530
Landing this will unblock the other generator blueprints listed in ^
TODO:
addon-importblueprint ifproject.isModuleUnification()