[Feature] util blueprint for module unification#16490
Merged
mixonic merged 1 commit intoemberjs:masterfrom Apr 27, 2018
Merged
Conversation
daibhin
force-pushed
the
dn/mu-utils-blueprint
branch
from
d1b05fd to
68c9641
Compare
daibhin
changed the title
daibhin
force-pushed
the
dn/mu-utils-blueprint
branch
3 times, most recently
from
d037383 to
bed42ae
Compare
daibhin
changed the title
daibhin
changed the title
daibhin
force-pushed
the
dn/mu-utils-blueprint
branch
from
bed42ae to
103a139
Compare
daibhin
changed the title
Member
|
@daibhin looking good, nice one! Can you also add some tests to util-test-test.js? The test files should be colocated with the util function file, much like |
daibhin
force-pushed
the
dn/mu-utils-blueprint
branch
from
103a139 to
e07054b
Compare
Contributor
Author
|
@GavinJoyce Updated the |
Member
|
running |
daibhin
force-pushed
the
dn/mu-utils-blueprint
branch
2 times, most recently
from
be2156a to
1293e2b
Compare
Contributor
Author
|
Sorry about that, fixed! I'm still trying to figure out which is more amazing |
Member
|
@daibhin as a final step, perhaps you could add an in-repo-addon test similar to this? This will ensure that we're not breaking existing functionality |
29 tasks
daibhin
force-pushed
the
dn/mu-utils-blueprint
branch
from
1293e2b to
48ee8e9
Compare
Member
|
nice one @daibhin, this looks great 👍 |
Member
|
Looks great! Thanks @daibhin :-D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of ember-cli/ember-cli#7530