Expand generate service blueprint test coverage#16553
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Apr 21, 2018
GavinJoyce:gj/expand-service-blueprint-test-coverage
Merged
Expand generate service blueprint test coverage#16553rwjblue merged 1 commit intoemberjs:masterfrom GavinJoyce:gj/expand-service-blueprint-test-coverage
rwjblue merged 1 commit intoemberjs:masterfrom
GavinJoyce:gj/expand-service-blueprint-test-coverage
Conversation
GavinJoyce
changed the title
This was referenced Apr 20, 2018
ghost
reviewed
Apr 20, 2018
| }); | ||
| }); | ||
|
|
||
| describe.only('in in-repo-addon', function() { |
There was a problem hiding this comment.
@GavinJoyce any reason the only is left in here?
rwjblue
approved these changes
Apr 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're making a number of changes to existing blueprints to enable MU output. While doing so, we should be careful not to break existing classic functionality.
This PR expands coverage of
ember generate serviceto include the following missing test cases:classic
ember generate service --in-repo-addon=my-addonember generate service --dummymodule unification (will come in a follow up PR once we've updated
in-repo-addonto MU)ember generate service --in-repo-addon=my-addonember generate service --dummyThis PR will then serve as a template for work on the other MU blueprints.