[WIP] [Feature] helper blueprint for module unification#16492
Closed
RuairiK wants to merge 2 commits intoemberjs:masterfrom
Closed
[WIP] [Feature] helper blueprint for module unification#16492RuairiK wants to merge 2 commits intoemberjs:masterfrom
RuairiK wants to merge 2 commits intoemberjs:masterfrom
Conversation
RuairiK
force-pushed
the
RK/helper-blueprint-pr
branch
2 times, most recently
from
f589d30 to
b16bb68
Compare
Member
|
It looks like we'll have to update ember-cli to skip LMK if you'd like to pair on this soon. Otherwise, I'll take this on later today |
This was referenced Apr 16, 2018
Member
|
@RuairiK ^ that's been resolved, perhaps you could rebase? Also, could you add an in-repo-addon test similar to this? This will ensure that we're not breaking existing functionality. |
29 tasks
RuairiK
force-pushed
the
RK/helper-blueprint-pr
branch
from
b16bb68 to
875d19f
Compare
Member
|
@RuairiK it looks like there are some failing blueprint tests |
Member
|
If anyone wants to pick this PR up, please do so |
This was referenced Nov 15, 2018
Contributor
|
#17211 continue and closes this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of ember-cli/ember-cli#7530