[Feature] Adds mixin blueprint for module unification#16524
[Feature] Adds mixin blueprint for module unification#16524rwjblue merged 1 commit intoemberjs:masterfrom
Conversation
beegan
force-pushed
the
jb/mixin-blueprint
branch
2 times, most recently
from
8e4719f to
e90bf46
Compare
|
Nice one @jackbeegan, this is looking great. |
|
@jackbeegan and I had a chat about his idea to increase test coverage to cover the following currently untested scenarios:
We both agree that it would be valuable to add this coverage in this PR, we can then use this as an example to increase coverage in a similar way for all other blueprints |
|
@jackbeegan I added some I also noticed that ember don't seem to support |
blueprints/mixin/index.js
Outdated
| }, | ||
| __testType__() { | ||
| return 'mixins'; | ||
| }, |
There was a problem hiding this comment.
I don't think we need this. ⚡️?
node-tests/blueprints/mixin-test.js
Outdated
| }); | ||
| }); | ||
|
|
||
| describe('in in-repo-addon - module unification', function() { |
There was a problem hiding this comment.
I haven't yet landed ember-cli/ember-cli#7783 so you can remove this test for now, it's not currently possible to test the desired behaviour of MU in-repo-addon blueprint output. I'll be sure to follow up and add these tests later
beegan
force-pushed
the
jb/mixin-blueprint
branch
from
172c2cf to
55331d9
Compare
|
Nice one @jackbeegan, this looks great. As a last step, perhaps you could squash, rebase and remove the WIP from the title? |
beegan
force-pushed
the
jb/mixin-blueprint
branch
4 times, most recently
from
73b58ce to
a5f051d
Compare
beegan
changed the title
|
@jackbeegan as a last step, can you prefix the commit message with |
beegan
force-pushed
the
jb/mixin-blueprint
branch
from
a5f051d to
60ed099
Compare
GavinJoyce
left a comment
GavinJoyce
left a comment
There was a problem hiding this comment.
CI Failures seems to be flakiness
👍 nice one @jackbeegan
|
@rwjblue this looks good to me and is ready for review. It seems that the test failure is just flaky CI |
beegan
force-pushed
the
jb/mixin-blueprint
branch
from
60ed099 to
df591a6
Compare
|
Thank you!! |
3 participants
Part of ember-cli/ember-cli#7530