[WIP] [Feature] instance-initializer blueprint for module unification#16491
[WIP] [Feature] instance-initializer blueprint for module unification#16491lbeauvilliers wants to merge 6 commits intoemberjs:masterfrom lbeauvilliers:lbeauvilliers/mu-instance-initializer-blueprint
Conversation
.idea/ember.js.iml
Outdated
| <orderEntry type="inheritedJdk" /> | ||
| <orderEntry type="sourceFolder" forTests="false" /> | ||
| </component> | ||
| </module> No newline at end of file |
There was a problem hiding this comment.
can you ⚡ these files (and perhaps add .idea/ to .gitignore)?
| ); | ||
|
|
||
| expect(_file('src/instance-initializers/foo-test.js')).to.contain( | ||
| "import { initialize } from 'my-app/instance-initializers/foo';" |
There was a problem hiding this comment.
I think this will have to change to point to the new path under src
There was a problem hiding this comment.
Thanks @GavinJoyce, changed that--now trying to figure out how to get the tests actually passing!
When I have this worked out, I'll move onto the addon case, then update instance-initializer-test-test.
|
We'll also need to add tests to instance-initializer-test-test.js to ensure that we're generating co-located tests. I added a similar comment here, it looks like we'll have to make a change in https://github.com/ember-cli/ember-load-initializers to allow tests to be co-located |
|
@lbeauvilliers ^ that's been resolved, perhaps you could rebase? Also, could you add an in-repo-addon test similar to this? This will ensure that we're not breaking existing functionality. LMK if you'd like to pair on this sometime |
|
If anyone wants to pick this PR up, please do so |
|
Can be closed by #17235 |
4 participants
To Do:
instance-initializer-test-test.js