Failing test to demonstrate query params bug

[rlivsey]

If there's:

1. a dynamic segment
2. a loading template
3. a route with a model hook that returns a promise
4. a query param defined

then the query param is not sticky on link-tos

Possibly related to #12107

Twiddle demonstrating the issue: https://ember-twiddle.com/97f2c3d7596c97d51846033ad23d75f2

[lifeart]

Maybe it's related bug - #14438

[rlivsey]

@lifeart ooh interesting, yes the conditions to trigger the bug do appear to be suspiciously similar

[lolmaus]

Hi! I'm the author of #14438, which was from 2016.

I've just ran into the issue described here, and my setup is much simpler than in #14438. We have a single query param in the whole app, some dynamic segments and no loading routes.

The query param is defined on a parent controller foo with a default value. When I go from foo.bar.index to foo.bar.baz and back (I don't even touch the query param property!), the URL is updated with explicit query param value, and the active class on the corresponding link-to is lost.

[lolmaus]

Hmm, in our case we make the via an action. Not sure if it matters.

[rreckonerr]

I just checked if emberjs/router.js#308 fixes your test case and it seems to work! Can someone else confirm it too?

[rwjblue]

Included (and fixed) in #19249, thanks again @rlivsey!