[BUGFIX beta] provide transition to setupContext for internal transit…#308
Merged
rwjblue merged 2 commits intoemberjs:masterfrom Nov 6, 2020
Conversation
rreckonerr
force-pushed
the
fix/provide-transition-object-for-internal-transitions
branch
from
c52be85 to
26765a3
Compare
rwjblue
reviewed
Nov 4, 2020
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Generally seems good, but we will need a test (that failed previously, and passes now) in order to confirm and to ensure we don't accidentally regress in the future...
Contributor
Author
|
@rwjblue Do we need a test case in this repo or in ember.js? I've already checked that this change fixes failing reproduction in ember.js emberjs/ember.js#16986 |
Member
I'd say both actually. |
…ions Prior emberjs@e792f2c we were calling `this.setupContext(newState, transition)` for intermediate transitions, which got replaced with `this.setupContexts(newState)`. This results in buggy behavior when query params get lost in certain scenarios. Refs: emberjs/ember.js#14438
rreckonerr
force-pushed
the
fix/provide-transition-object-for-internal-transitions
branch
from
26765a3 to
0be0d19
Compare
3 tasks
Contributor
Author
|
@rwjblue I've prepared a PR in ember.js repo with failing tests fixed by this PR emberjs/ember.js#19249 |
rwjblue
approved these changes
Nov 6, 2020
Member
|
Awesome, thank you @rreckonerr! |
Member
|
Just released as v7.1.1, would you mind sending an Ember PR with the previously failing test (along with the upgrade)? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ions
Prior e792f2c we were calling
this.setupContext(newState, transition)for intermediate transitions, which got replaced withthis.setupContexts(newState). This results in buggy behavior when query params get lost in certain scenarios.Refs: emberjs/ember.js#14438
Closes emberjs/ember.js#14438 (hopefully)