[Deprecation] Artisanally crafted deprecation for @rwjblue#17193
Merged
chadhietala merged 1 commit intomasterfrom Dec 7, 2018
Merged
[Deprecation] Artisanally crafted deprecation for @rwjblue#17193chadhietala merged 1 commit intomasterfrom
chadhietala merged 1 commit intomasterfrom
Conversation
rwjblue
reviewed
Nov 8, 2018
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Looks good, we need to add a deprecation guide entry for it and cross link that url in the deprecation here.
Member
|
Ping @chadhietala, I think this just needs a deprecation guide and URL |
rwjblue
requested changes
Dec 7, 2018
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
The deprecation guide is published now at:
https://emberjs.com/deprecations/v3.x/#toc_component-manager-string-lookup
Would you mind updating the deprecation call just above to add url: 'https://emberjs.com/deprecations/v3.x/#toc_component-manager-string-lookup'?
Member
|
Also seems to need a rebase... |
chadhietala
force-pushed
the
impl-rfc-392
branch
from
4f98b22 to
1090fdd
Compare
rwjblue
approved these changes
Dec 7, 2018
chadhietala
force-pushed
the
impl-rfc-392
branch
from
1090fdd to
26d9bc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements emberjs/rfcs#392.
100% Shade Grown Deprecations