Refactor component blueprint tests to use fixtures#17198
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Nov 21, 2018
Merged
Refactor component blueprint tests to use fixtures#17198rwjblue merged 1 commit intoemberjs:masterfrom
rwjblue merged 1 commit intoemberjs:masterfrom
Conversation
simonihmig
added a commit
to simonihmig/ember-cli-typescript-blueprints
that referenced
this pull request
Nov 10, 2018
Adds support for ember-mocha 0.14 Tests are copied from ember.js, after making them based on fixtures through emberjs/ember.js#17198
simonihmig
force-pushed
the
component-blueprint-test-fixtures
branch
from
30c2d2a to
f512daf
Compare
Contributor
Author
|
@rwjblue thanks for merging the other blueprint PRs so quickly! What about this one? Any concerns I can address? |
This was referenced Nov 16, 2018
Closed
Contributor
|
#17212 may supersede this PR |
simonihmig
added a commit
to simonihmig/ember-cli-typescript-blueprints
that referenced
this pull request
Nov 22, 2018
Adds support for ember-mocha 0.14 Tests are copied from ember.js, after making them based on fixtures through emberjs/ember.js#17198
simonihmig
added a commit
to simonihmig/ember-cli-typescript-blueprints
that referenced
this pull request
Nov 22, 2018
Adds support for ember-mocha 0.14 Tests are copied from ember.js, after making them based on fixtures through emberjs/ember.js#17198
simonihmig
added a commit
to simonihmig/ember-cli-typescript-blueprints
that referenced
this pull request
Nov 30, 2018
Adds support for ember-mocha 0.14 Tests are copied from ember.js, after making them based on fixtures through emberjs/ember.js#17198
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a bit trickier than the previous refactorings, as with nested components and different paths the combinations exploded a bit, and having a separate fixture file for each of them would have been a bit too much. So...
foo's,x-foo's,bar's and whatnot. But the semantics of each test hasn't been changed.fixturehelper a bit to optionally support some string replacement (templating) functionality, to not have a dozen slightly different test fixtures (given different combinations of component names and paths)