Skip to content

Update to ember-cli@3.5.0.#17126

Closed
rwjblue wants to merge 2 commits intoemberjs:masterfrom
rwjblue:unpin-ember-cli
Closed

Update to ember-cli@3.5.0.#17126
rwjblue wants to merge 2 commits intoemberjs:masterfrom
rwjblue:unpin-ember-cli

Conversation

@rwjblue
Copy link
Member

@rwjblue rwjblue commented Oct 17, 2018

Brings loads of changes/fixes, but the reason I did it was to start using Broccoli 2...

Brings loads of changes/fixes, but the reason I did it was to start
using Broccoli 2...
@Turbo87
Copy link
Member

Turbo87 commented Oct 18, 2018

looks like some blueprint-related things are breaking 🤔

@rwjblue
Copy link
Member Author

rwjblue commented Oct 18, 2018

Yeah, its because the tests are setup to expect the wrong thing by default ember new foo. Its going to be a bit of a chore to fix 😩.

@rwjblue
Copy link
Member Author

rwjblue commented Oct 18, 2018

I pushed one commit with fixes for acceptance-test file to show what I mean.

@Turbo87
Copy link
Member

Turbo87 commented Oct 18, 2018

oh... that makes sense... 😞

@ppcano
Copy link
Contributor

ppcano commented Nov 16, 2018

@simonihmig Will #17207 and #17198 finally unblock the ember-cli@3.5 upgrade or there are something else that needs to be done.

I am working on the MU blueprints and I would like to test with new versions of ember-cli and ember-cli-blueprint-test-helpers.

@simonihmig
Copy link
Contributor

Will #17207 and #17198 finally unblock the ember-cli@3.5 upgrade or there are something else that needs to be done.

@ppcano I guess there are a few more blueprints that need to be "fixed", which I haven't touched yet (e.g. mixins). I believe making each single test explicit about the test framework version used is the key here, as in this example: https://github.com/emberjs/ember.js/pull/17207/files#diff-b1525449225102a81123371a3a8c87f8R26

@ppcano ppcano mentioned this pull request Nov 16, 2018
3 tasks
@ppcano
Copy link
Contributor

ppcano commented Nov 16, 2018

#17212 supersedes this PR

@rwjblue
Copy link
Member Author

rwjblue commented Nov 19, 2018

Thank you @ppcano!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants