Conversation
|
Needs a rebase, but should be green after... |
|
Restarted browserstack job. |
|
Thank you very much @Turbo87! |
| @@ -0,0 +1,13 @@ | |||
| function enableModuleUnification() { | |||
| beforeEach(function() { | |||
There was a problem hiding this comment.
Hi @Turbo87
At #17212, I was enabling MU differently because that PR also upgraded ember-cli-blueprint-test-helpers@0.19.1 which implements a new API described at ember-cli/ember-cli-blueprint-test-helpers#153
emberNew({ isModuleUnification: true })
-
Do we want to upgrade
ember-cli-blueprint-test-helpersand use the new API? I can work on this PR but I would like to have a confirmation first. -
In order the suggested PR to work, Reset blueprint's ignoredFiles ember-cli/ember-cli#8240 needs to be merged.
There was a problem hiding this comment.
from what I can tell emberNew({ isModuleUnification: true }) does basically the same thing as the setupModuleUnification() that I introduced here. feel free to update it. I don't know how ember-cli/ember-cli#8240 is related to this though.
3 participants
Closes #17212, Closes #17126