Skip to content

WIP: Add basic decorator transpilation infrastructure#17404

Closed
Turbo87 wants to merge 3 commits intoemberjs:masterfrom
Turbo87:decorator-basics
Closed

WIP: Add basic decorator transpilation infrastructure#17404
Turbo87 wants to merge 3 commits intoemberjs:masterfrom
Turbo87:decorator-basics

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 21, 2018

This PR applies the necessary changes to the build pipeline to transpile the ESnext Decorators to regular ESlatest code. It also adds a basic smoke test to ensure that everything works as expected.

/cc @NullVoxPopuli

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 21, 2018

weeeeeell, turns out IE11 doesn't like the transpilation because it's using Symbol, which is apparently not available yet in IE11

(see https://gist.github.com/Turbo87/ad9724050bd85388228c8c81c2afea36)

@Turbo87
Copy link
Member Author

Turbo87 commented Jan 16, 2019

closing this until we figure out how to avoid this issue with IE11

@Turbo87 Turbo87 closed this Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants