WIP: Decorator Implementation#17226
Closed
NullVoxPopuli wants to merge 10 commits intoemberjs:masterfrom
Closed
Conversation
NullVoxPopuli
force-pushed
the
implement-decorators
branch
2 times, most recently
from
e2ca5be to
fbedc41
Compare
NullVoxPopuli
commented
Dec 7, 2018
NullVoxPopuli
force-pushed
the
implement-decorators
branch
from
4ff12d0 to
de44861
Compare
NullVoxPopuli
force-pushed
the
implement-decorators
branch
from
16cb2fd to
39b0427
Compare
Turbo87
reviewed
Dec 21, 2018
Contributor
|
|
pzuraq
reviewed
Jan 8, 2019
Contributor
|
Tests are invaluable @NullVoxPopuli, keep up the good work! |
NullVoxPopuli
force-pushed
the
implement-decorators
branch
from
a7265d0 to
a252110
Compare
…mixin tree...........
Contributor
|
Does #17548 supersede this PR? |
Contributor
|
Yes it does, closing since we merged the feature in a different PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not only is this a WIP, but the RFC still needs to be merged / accepted.
Soon! ™️
Hopefully this can be merged first: #17404
:)
Outstanding work:
_super) support