Merged
Conversation
pzuraq
force-pushed
the
implement-decorators
branch
2 times, most recently
from
a49dbb5 to
443e536
Compare
Contributor
Author
|
Thanks @richard-viney! |
ro0gr
reviewed
Feb 4, 2019
pzuraq
force-pushed
the
implement-decorators
branch
5 times, most recently
from
0cebdcb to
4359400
Compare
Contributor
Author
|
Benchmarked, no statistically significant change in performance when used in classic class syntax! I think this is ready for review 🎉 |
pzuraq
force-pushed
the
implement-decorators
branch
2 times, most recently
from
99d5213 to
df39f05
Compare
pzuraq
commented
Feb 5, 2019
pzuraq
commented
Feb 5, 2019
| @type DOMElement | ||
| @public | ||
| */ | ||
| element: descriptor({ |
Contributor
Author
There was a problem hiding this comment.
Followup: We should flatten this class into Component so we don't need to use this decorator
2 tasks
pzuraq
force-pushed
the
implement-decorators
branch
from
6f95d66 to
3ecf45b
Compare
pzuraq
commented
Feb 6, 2019
pzuraq
commented
Feb 6, 2019
pzuraq
commented
Feb 6, 2019
pzuraq
force-pushed
the
implement-decorators
branch
5 times, most recently
from
93d42b1 to
d3a6a24
Compare
This PR refactors the Descriptor system in Ember metal, mostly replacing it with a Decorator system instead. `defineProperty` has been updated to apply decorators following the currently implemented spec. This means that the value returned by `computed` goes through the exact same flow when applied as a decorator using decorator syntax, and applied using classic syntax.
pzuraq
force-pushed
the
implement-decorators
branch
from
d3a6a24 to
53b84e2
Compare
buschtoens
reviewed
Mar 4, 2019
| _dependentKeys: string[] | undefined; | ||
|
|
||
| constructor(config: ComputedPropertyConfig, opts?: ComputedPropertyOptions) { | ||
| constructor(args: Array<string | ComputedPropertyConfig>) { |
Contributor
There was a problem hiding this comment.
Was this change intentional? Shouldn't it be ...args instead?
Contributor
There was a problem hiding this comment.
Confirmed on Discord that it is intentional.
This was referenced Mar 17, 2019
15 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #17226, thanks a ton to @NullVoxPopuli for getting this started!
This PR refactors the Descriptor system in Ember metal, mostly replacing
it with a Decorator system instead.
definePropertyhas been updated toapply decorators following the currently implemented spec. This means
that the value returned by
computedgoes through the exact same flowwhen applied as a decorator using decorator syntax, and applied using
classic syntax.
I was considering pulling out the ComputedDecorator stuff into a separate
package, it's relatively isolated from the rest of
metalat this pointso it would make some sense. Thoughts?
TODO: