[DEPRECATION] Deprecate globals resolver

[Gaurav0]

For emberjs/rfc-tracking#20

• Deprecate instantiating @ember/application/globals-resolver (in init of packages/@ember/application/globals-resolver.ts)
• Deprecate using Ember.Resolver / Ember.DefaultResolver (in packages/ember/index.js)

[runspired]

YEAAAAAASSSSSSSSSSSS cc @scalvert I was just complaining to you that this still existed the other day :D

[Gaurav0]

Thank you for reviewing and providing feedback, @rwjblue . I'm working on this.

[Gaurav0]

@rwjblue Updated. I hope this alleviates most of your concerns.

[rwjblue]

Thanks for working on this!

[rwjblue]

Hmm, why do we need to clear the assertions?

[Gaurav0]

In beforeEach we are creaing an application using the default resolver. This throws off the following assert.expect statements.

[rwjblue]

Gotcha, so lets split the tests that rely on the globals resolver into their own moduleFor + class (e.g. moduleFor('Application Dependency Injection - Globals Resolver [DEPRECATED]', class extends TestCase {})).

[Gaurav0]

There's only one test that relies on it, so I'm just going to move it into default_resolver_test.js.

[rwjblue]

I think we also need to add some svelting conditionals (so we can strip the deprecated code paths). The basic steps for this are:

• add another entry to @ember/deprecated-features
• import that flag in any file that implements the deprecated behavior (I think this is mostly the location that the globals resolver itself is defined)
• wrap the implementation code in an if (GLOBALS_RESOLVER) {

Some example PRs that have landed that might be helpful:

• Deprecate {{partial}} #18491
• [DEPRECATION] deprecate Component#isVisible #17948
• [DEPRECATION] Add deprecation for Function.prototype extensions. #17910
• Add svelte support for jQuery deprecations #17525

[rwjblue]

Looks great, only one minor nit-pick left.

[rwjblue]

Thank you @Gaurav0!

[Gaurav0]

Thank you @rwjblue !