Merged
Conversation
4 tasks
GavinJoyce
force-pushed
the
gj/deprecate-partial
branch
2 times, most recently
from
0dd69ec to
f6fda97
Compare
2 tasks
rwjblue
reviewed
Oct 25, 2019
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Do you think there is a way to make it so all of packages/@ember/-internals/views/lib/system/lookup_partial.js can be stripped (aka svelted)? Can we inline that module into here:
And remove the various reexports and whatnot?
GavinJoyce
force-pushed
the
gj/deprecate-partial
branch
from
b7123ac to
ff9e96b
Compare
Member
Author
|
Good call, I've moved |
rwjblue
approved these changes
Oct 25, 2019
| assert(`templateNames are not allowed to contain periods: ${name}`, name.indexOf('.') === -1); | ||
|
|
||
| if (!owner) { | ||
| throw new EmberError( |
Member
There was a problem hiding this comment.
This error is a bit "wild", but 🤷♂
Member
|
Thank you! |
2 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of emberjs/rfc-tracking#38
Supersedes #14972
TODO:
{{partial}}as@deprecated{{partial}}ember-learn/deprecation-app#456