create and (trying to) fix async loading of Routes

[sly7-7]

This is a follow up of #19266

[rwjblue]

Chatted a bit with @sly7-7 about this in discord this morning, the conclusion we came to was that Ember should never attempt to enter into a loading or error route that itself is not loaded.

I believe that @sly7-7 is going to update this code:

ember.js/packages/@ember/-internals/routing/lib/system/router.ts

Lines 1411 to 1416 in b945e5c

	function routeHasBeenDefined(owner: Owner, router: any, localName: string, fullName: string) {
	let routerHasRoute = router.hasRoute(fullName);
	let ownerHasRoute =
	owner.hasRegistration(`template:${localName}`) || owner.hasRegistration(`route:${localName}`);
	return routerHasRoute && ownerHasRoute;
	}

Check that getRoute returns a non-promise before returning true.

Something like:

function routeHasBeenDefined(owner: Owner, router: any, localName: string, fullName: string) {
  let routerHasRoute = router.hasRoute(fullName);
    
  if (routeHasRoute && !isPromise(router.getRoute(fullName))) {
    let ownerHasRoute =
      owner.hasRegistration(`template:${localName}`) || owner.hasRegistration(`route:${localName}`);

    return ownerHasRoute;
  }

  return false;
}

[sly7-7]

@rwjblue I have doubt about that artificial synchronisation

[sly7-7]

Just a reminder to me, to remove this test

[sly7-7]

Not sure if the name fits well.

[sly7-7]

@rwjblue Hi, so I've played with that PR, and I'm blocked, mainly because I miss knowledge on the testing infrastructure, and also when it comes to engines.
It seems to me that I need some waiters helpers (in order to check the loading states), but I couldn't find a way to make them work.
Also, I noted this test: https://github.com/emberjs/ember.js/blob/master/packages/@ember/-internals/glimmer/tests/integration/application/engine-test.js#L26 use quite but not the same routerOptions() as in the 'helper' I created. I was wondering if their purposes are the same or not.
Let me know when we can eventually schedule a chat to talk about that, or if you see what I mean here, you could also help me with tiny snippets here. As you prefer :)

[kategengler]

Is this still relevant?

[sly7-7]

@kategengler I'm sorry I didn't notice your question until now 😞 I don't know if this is still relevant, as far as I remember, an error could happen when a route is loaded by an engine.
There was also a PR in the router emberjs/router.js#322 and quickly looking at the code this one may be still relevant (but lack of tests that I failed to write).
I don't know if the router in ember has been touched sinced 3 years now, but if nothing has changed, then maybe this PR also could be relevant. I've never encountered this use-case in prod app, so I couldn't tell if the bug mentioned could really occur.

[bwbuchanan]

I'm still seeing this stashParamNames error in an app I'm developing that makes use of loading states. Have been working around it for a while by applying the patch in #19266