delete context during setup only if route is defined#322
Open
sly7-7 wants to merge 1 commit intoemberjs:masterfrom
Open
delete context during setup only if route is defined#322sly7-7 wants to merge 1 commit intoemberjs:masterfrom
sly7-7 wants to merge 1 commit intoemberjs:masterfrom
Conversation
rwjblue
reviewed
Mar 9, 2021
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
This seems like the right change here. I would definitely like to add a test here to try to prevent an accidental regression, I think it would fit with these tests:
https://github.com/tildeio/router.js/blob/master/tests/async_get_handler_test.ts
Member
|
@sly7-7 status? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary for emberjs/ember.js#19266
@rwjblue Do you think there could be a demonstrating failing test in this repo ?