Skip to content

Enable EMBER_TYPESCRIPT_BLUEPRINTS flag#20352

Merged
chriskrycho merged 1 commit intoemberjs:masterfrom
bertdeblock:enable-EMBER_TYPESCRIPT_BLUEPRINTS-flag
Jan 20, 2023
Merged

Enable EMBER_TYPESCRIPT_BLUEPRINTS flag#20352
chriskrycho merged 1 commit intoemberjs:masterfrom
bertdeblock:enable-EMBER_TYPESCRIPT_BLUEPRINTS-flag

Conversation

@bertdeblock
Copy link
Member

@bertdeblock bertdeblock commented Jan 13, 2023

Closes #20177.

chriskrycho
chriskrycho reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good here – let me know when you're ready to move it out of Draft!

@bertdeblock bertdeblock marked this pull request as ready for review January 19, 2023 07:25
@bertdeblock
Copy link
Member Author

bertdeblock commented Jan 19, 2023

@chriskrycho Done! Was mostly waiting on a "good to go", wasn't sure if we could already land this.

@chriskrycho chriskrycho mentioned this pull request Jan 19, 2023
Closed
26 tasks
@chriskrycho
Copy link
Contributor

chriskrycho commented Jan 19, 2023

Yeah, let me do a quick pass on the actual blueprints to make sure they're good, but/and we should have folks kick the tires a bunch during the 4.12 beta cycle—that’s what the beta cycle is for!

@chriskrycho
Copy link
Contributor

chriskrycho commented Jan 19, 2023

We need to add the service registry to the service blueprints, but I believe we're otherwise good to go; I'm putting up a PR to do that now.

@chriskrycho chriskrycho mentioned this pull request Jan 19, 2023
Merged
@chriskrycho
Copy link
Contributor

chriskrycho commented Jan 19, 2023 •
edited
Loading

Chatting with @cafreeman, he reminded me that we also need the blueprints to support generating signatures for components! And the same will go for helper classes, and we should make sure ember-modifier’s blueprints are updated as well.

@chriskrycho chriskrycho mentioned this pull request Jan 19, 2023
Merged
@chriskrycho
Copy link
Contributor

chriskrycho commented Jan 20, 2023

All right, let's do this! 🎉 🚀

@chriskrycho chriskrycho merged commit 2ffa7db into emberjs:master Jan 20, 2023
@chriskrycho chriskrycho added Feature TypeScript Work on Ember’s types labels Jan 20, 2023
@bertdeblock bertdeblock mentioned this pull request Jan 31, 2023
Closed
@ijlee2 ijlee2 mentioned this pull request Apr 5, 2023
Merged
@bertdeblock bertdeblock mentioned this pull request Dec 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chriskrycho chriskrycho chriskrycho left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature TypeScript Work on Ember’s types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable EMBER_TYPESCRIPT_BLUEPRINTS feature

2 participants

@bertdeblock @chriskrycho