Clean up EMBER_TYPESCRIPT_BLUEPRINTS feature flag#20809
Merged
kategengler merged 2 commits intoemberjs:mainfrom Dec 20, 2024
Merged
Clean up EMBER_TYPESCRIPT_BLUEPRINTS feature flag#20809kategengler merged 2 commits intoemberjs:mainfrom
EMBER_TYPESCRIPT_BLUEPRINTS feature flag#20809kategengler merged 2 commits intoemberjs:mainfrom
Conversation
bertdeblock
force-pushed
the
clean-up-blueprints
branch
2 times, most recently
from
87b1ade to
81e147b
Compare
bertdeblock
force-pushed
the
clean-up-blueprints
branch
from
81e147b to
693bfdb
Compare
bertdeblock
commented
Dec 9, 2024
| module.exports = { | ||
| description: 'Generates an import wrapper.', | ||
|
|
||
| shouldTransformTypeScript: true, |
Member
Author
There was a problem hiding this comment.
*-addon blueprints (app re-exports) always need to generate JS files, so no need to try and transform TS -> JS for these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was enabled by default almost two years ago.
Seems like we can clean this up, and remove all
blueprints-jsfiles from this repo?