Draft
Conversation
7189c1b to
ea77328
Compare
package.json
Outdated
| "@ember/controller/index.js": "ember-source/@ember/controller/index.js", | ||
| "@ember/debug/container-debug-adapter.js": "ember-source/@ember/debug/container-debug-adapter.js", | ||
| "@ember/debug/data-adapter.js": "ember-source/@ember/debug/data-adapter.js", | ||
| "@ember/debug/ember-inspector-support/adapters/basic.js": "ember-source/@ember/debug/ember-inspector-support/adapters/basic.js", |
Contributor
There was a problem hiding this comment.
do all of these need to be separate entries here? or can we bundle it all under ember-inspector-support.js?
Contributor
Author
There was a problem hiding this comment.
I'm not sure if it was me or some automated task that did this. Probably not necessary to have all here. Should never be directly imported by client code
Contributor
|
The two major points of feedback we discussed about this are:
|
c406d6c to
978fa1a
Compare
Contributor
Author
|
as a first step i reduces the files that are accessing ember |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs
inspector needs: