Enable deprecate-import-from-ember deprecation#20813
Enable deprecate-import-from-ember deprecation#20813kategengler merged 2 commits intoemberjs:mainfrom
deprecate-import-from-ember deprecation#20813Conversation
|
Could you bring this comment to the RFC? That's really where enabled gets decided -- the 'Ready for Release' stage |
|
There is already a wip pr for compatibility #20775 . |
|
My preference would be to ditch AMD, even for the inspector 🙈 |
|
Then we can just work on #20775 :) |
I'll review soon (Tomorrow?) |
deprecate-import-from-ember deprecation
What are folks thoughts on enabling this? and then the deprecation messages would force us to work on improving the inspector experience?
I have some ideas for how to bring back compatibility.
Our setup would be something like this:
This should probably wrap all of this code: https://github.com/emberjs/ember.js/pull/20775/files#diff-b2c569a1648b65b7314971b3bd201a82fda450a5cccc8c3d415b864166c98e27
And then on the app side, we only need to load the module, since everything the inspector needs is await-imported
And then on the inspector side, we access the globalThis
@PatrickJS , @ef4 thoughts?