Route inherits parent's model by default.

[locks]

Opening up discussion to address Core f2f proposal: unspecified this.route() models default to parent resource.

Went with the simplest approach I could think of to make it work. All tests passing locally, including the one introduced.
Looking for c+c, thanks in advance :)

Possible improvements:

• Test nested route
• Test more than one level of nesting
• features.json
• FEATURES.md
• prefix commit
• only leaf route/resources inherit model

[machty]

I think this is correct. You'll just need to wrap in a ember-route-inherits-parent-model flag and prefix commit with [FEATURE ember-route-inherits-parent-model]

[locks]

Pushed corrections to the points raised.

[rwjblue]

@locks - Could you change the feature flag to ember-routing-inherits-parent-model? Generally, we like the prefix to match the package that it is modifying.

[locks]

Done.

[jonnii]

This is how I'll feel once this get merged and I can delete a bunch of routes:

[ebryn]

lulz

[wagenet]

@machty, @ebryn Did this get discussed in a core team meeting? If not, we should probably give it a quick Go or No-Go before we merge.

[machty]

Basically it's gonna take some more convincing to do this for ALL routes, rather than just routes declared via this.route().

The plan is we'll accept this feature for route routes and not resource routes. @locks if you wanna make the change, I believe you can simply add a check to only perform this behavior if resolveIndex === handlerInfos.length-1. Once that's in we'll approve this, and in the future we may add universal support (to include this.resource routes), but we can save that discussion for later.

[locks]

I will make the necessary changes tomorrow.

[locks]

Updated.

[rwjblue]

@locks - Looks like a rebasing issue. I see 8 commits in this PR...

[locks]

My bad, PR rebased.

[machty]

i have doubts about this line, talking with @locks on irc about it

[locks]

Well spotted, turns out I was doing it backwards. Coupled with a typo, the tests weren't even triggering.

[machty]

@jonnii et al, with this fix, let us know if/when/how often you have a resource route that doesn't inherit but would be convenient to inherit; as mentioned in an earlier comment, we're only supporting routes (not resources) inheriting parent models, so we're curious how often people really need resources to inherit and why.

[jonnii]

@machty the main usecase is for routes, not for resources, so I think limiting it to them is fine. We can delete a bunch of routes that looks like:

App.ZomgEditRoute = App.AuthenticatedRoute.extend
  model: ->
    @modelFor 'zomg'

How does this affect the implicit index route you get when doing this.resource('zomg', function(){})?

[ef4]

I think it's worth readdressing whether all routes can't simply inherit their parent route's models by default. Now that route supports nested children, the existing check:

if (transition.resolveIndex !== transition.state.handlerInfos.length-1) { return; }

isn't even really correct anymore. I found this thread because I was wondering why the heck only leaf routes can inherit their parent's model. I definitely have use cases for it elsewhere. Any leaf route can eventually grow the need for children of its own.

[stefanpenner]

@ef4 i think inheriting by default seems correct regardless of depth