[BUGFIX beta] Fix ember-routing-inherits-parent-model for nestable routes.

[ef4]

When the original ember-routing-inherits-parent-model feature was accepted, it was decided that routes could inherit their parent's model but resources couldn't.

But now the distinction between those two is smaller than ever, and the existing check is actually wrong, since it excludes routes with children.

I'm proposing we scrap this legacy distinction and just let any route inherit.

[mixonic]

This test should only be run if the feature is enabled?

[ef4]

Right! Thanks.

[stefanpenner]

@wycats r?

[rwjblue]

👍 from me

[rwjblue]

@ef4 - All features need to add an entry in features.json (value should be null) and FEATURES.md.

[rwjblue]

Now that I think about this more, this kinda feels like a bugfix not really a "new feature".

Any objections to just using [BUGFIX beta]?

[ef4]

I added it to the feature files.

BUGFIX is fine too. One could argue that this should have been part of the nested-route change. I don't know of any cases where this will break people's apps unless they're way off the happy path.

[rwjblue]

Yes, exactly my thoughts. If I had thought of it, I would have change this when I did the nested route stuff. I'll flag for review in the core team meeting today to decide on BUGFIX or FEATURE.

[rwjblue]

Just discussed this in the core team meeting. Definitely a BUGFIX.

@ef4 - Can you remove the feature flagging, and update the commit prefix with [BUGFIX beta]? Also, sorry for the mixed signals here..