Conversation
wagenet
added
S-Exploring
Contributor
|
one thing comes to mind which does not seem to be mentioned - Ember Data extends |
Member
Author
|
@SergeAstapov @ember/error literally just re-exports native Error. What's your concern here? |
chriskrycho
approved these changes
Dec 15, 2022
Contributor
There was a problem hiding this comment.
DO IT.
When we say "super easy codemod," by the way, we mean a super easy codemod:
npx jscodeshift -t https://gist.githubusercontent.com/astexplorer/5f88840599701bae9452cea55e86641e/raw/8538fbcc97c01fe77c42b035613a43b26d206a93/transform.js <glob of files>I've run this against the big LI app and it works correctly! 🎉
Contributor
|
@wagenet tbh not a concern. maybe even not need to be explicitly stated. Ember Data just would need to account for that I assume |
Member
Author
|
Per the core team meeting today, we're moving this to FCP to merge. |
8 tasks
wagenet
added a commit
that referenced
this pull request
Jan 10, 2023
Advance RFC #889 to Stage Ready for Release
3 tasks
wagenet
added a commit
that referenced
this pull request
Jan 14, 2023
Advance RFC #889 to Stage Released
7 tasks
wagenet
added a commit
that referenced
this pull request
Mar 3, 2023
Advance RFC #889 "Deprecate @ember/error" to Stage Recommended
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered