Skip to content
This repository was archived by the owner on Mar 22, 2019. It is now read-only.

Community Page Updates + New Meetups Page#1904

Merged
wifelette merged 79 commits intoemberjs:masterfrom
sandraor:master
Jan 27, 2015
Merged

Community Page Updates + New Meetups Page#1904
wifelette merged 79 commits intoemberjs:masterfrom
sandraor:master

Conversation

@sandraor
Copy link
Contributor

@sandraor sandraor commented Jan 2, 2015

I need some help to finish the new Meetups page. It's using Google Maps for Rails: https://github.com/apneadiving/Google-Maps-for-Rails

To do

Code

Content

  • Fill in any missing information (the "Start your own meetup" section in particular). (@wifelette)

Names in parenthesis indicate the tasks have been claimed. Then we'll check them off once the work is complete and merged back in.

@wifelette
Copy link
Member

This is awesome :D

I'll work on the missing info section content.

Hoping we can get some help here from some others...

@wifelette wifelette changed the title New Community pages Community Page Updates + New Meetups Page Jan 2, 2015
@wycats
Copy link
Member

wycats commented Jan 5, 2015

@sandraor Do you think you could rebase this PR? It seems to have diverged somewhat from master, and I'm not personally sure how to resolve all of the conflicts.

@sandraor
Copy link
Contributor Author

sandraor commented Jan 5, 2015

@wycats Sure — it's up to date now.

data/meetups.yml Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this section includes Wellington, New Zealand should it maybe be Australasia instead of Australia?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about South Pacific?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oceania seems the correct term for the region.

Clean up JS, move options to yaml file
@andrewbranch
Copy link
Contributor

Is anyone already working on the meetups group columns? Thinking about trying to tackle that. Would a Middleman extension be the best place to do some logic to try to balance the groups into even columns?

@wifelette
Copy link
Member

@andrewbranch I can't comment on the Middleman bits... but the task is all yours, thanks for the help :D

@wifelette
Copy link
Member

@sandraor OKAY! It's way beyond my bedtime, but I got excited about making progress on this :p

My latest PR tackles several of the ToDos.

Right now, the map is doing the geolocation (assuming you give the browser permission to detect), but there's only one marker on it, Atlanta. Looks like you hardcoded that in, yes?

Question being, what's the plan for getting them all in there? Do we need to add lat/long parameters to the yaml file? Same question RE: organizer info—looks like you hardcoded it for now. What's the plan now that we're ready to add everyone else's data?

Also, something strange that I was only able to repro a couple times, so I'm unsure if it's still a problem right now. The Ember logo (in the nav) was jumping up in size ever so slightly only on this new Meetup page... let me know if you see it. If not, since I was only able to repro intermittently, we can drop until we see it again :p

wifelette and others added 2 commits January 8, 2015 23:46
@wifelette
Copy link
Member

Current status, FYI:
@wycats added a bunch of comments/suggestions to sandraor#11. Once that's all sorted, we should be good to merge back in :)

@lzcabrera Poke me or @wycats if you have questions about his questions :p I'll make sure he responds.

@lzcabrera
Copy link
Contributor

@wifelette i've incorporated @wycats suggestions in sandraor#11.

I think it is ready to be merged back in :)

@wifelette
Copy link
Member

Awesome!

@sandraor I'll try and get @wycats and/or @rwjblue to do a final pass on the final product and give us a thumbs up.

ETA on the Resources page we're working on? I'm around via chat and Trello to sort out any details on that :)

TL;DR: this is good to go/be merged (pending review) but we'll need to wait until we have the resources page + affiliated YAML file data to merge this. Hopefully it'll be pretty quick, and I don't anticipate any other changes to the page in the meantime, so we should stay current/able to be automatically merged.

@sandraor
Copy link
Contributor Author

Is it possible to change the zoom levels of the map for different situations? When location detection is on, it's at zoom level 8 and centred on the user's location. However, when location detection is turned off, the map is centred in the middle of the ocean at the same zoom level, so it looks entirely blue. If it's possible to specify, these are the ideal zoom levels:

Default zoom level: 2
Location detection enabled: 8
Pin selected: 14

@lzcabrera
Copy link
Contributor

@sandraor I'm looking into the zoom levels and have a fix almost in place, I will be adding it to sandraor#13
While working on this fix I noticed the cluster images are returning a 404:

/images/meetups/map-cluster-1.png
If this is an an asset from a gem, add sprockets.import_asset 'map-cluster-1.png' to your config.rb.

I'm not sure what's going on here. The cluster images were working a few days ago and the images are in the right place.

Default zoom level: 2
Location detection enabled: 8
Pin selected: 14
@lzcabrera
Copy link
Contributor

@sandraor checkout sandraor#13, I added the zoom levels fix

Anyone know how to fix the 404 errors on /images/meetups/map-cluster-1.png and /images/meetups/map-cluster-2.png?

When typing the path to those images on the browser, ie: http://localhost:4567/images/meetups/map-cluster-1.png I get:
"If this is an an asset from a gem, add sprockets.import_asset 'map-cluster-1.png' to your config.rb."

@yaymukund
Copy link

@lzcabrera I checked out lzcabrera/meetup-list, ran bundle && bundle exec middleman and visited http://0.0.0.0:4567/meetups and it fetches both files without issue.

@lzcabrera
Copy link
Contributor

Thanks for checking @yaymukund. I was still seeing the issues after running bundle && bundle exec middleman. I restarted my terminal and now it is working fine :)

sandraor and others added 5 commits January 18, 2015 00:34
wifelette added a commit that referenced this pull request Jan 27, 2015
Community Page Updates + New Meetups Page
@wifelette wifelette merged commit bbce792 into emberjs:master Jan 27, 2015
@wifelette
Copy link
Member

Just merged this back in and it's live! Woot!

Big thanks and super congrats to everyone who was learning the ropes on this one, especially @sandraor. Y'all did a great job, and I hope you'll stick around and help with future projects too <3

@owain
Copy link

owain commented Mar 6, 2015

Just wondering if anyone is working on the resources page? Is there a design or plan for it?

@wifelette
Copy link
Member

Blocked on me, sad face :( Too much EmberConf!

@sandraor has ideas for the design and I'm needing to get her the content plan. Will be getting back to it as soon as I get everything settled again!

@owain
Copy link

owain commented Mar 6, 2015

pfft...excuses! 😜

No, totally understandable! Let me know if I can help. And great job with EmberConf, loved it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.