Skip to content

Clean up JS, move options to yaml file#1

Merged
sandraor merged 2 commits intosandraor:masterfrom
yaymukund:meetups-dot-js
Jan 9, 2015
Merged

Clean up JS, move options to yaml file#1
sandraor merged 2 commits intosandraor:masterfrom
yaymukund:meetups-dot-js

Conversation

@yaymukund
Copy link

Hi, I read emberjs#1904 and thought I'd take a stab at cleaning up the JS. This branch does two things:

  • Move JS to its own file.
  • Move google maps options to YML.

@rwjblue
Copy link

rwjblue commented Jan 8, 2015

👍

@rwjblue
Copy link

rwjblue commented Jan 8, 2015

@sandraor - Please review, but this looks good to me (thanks @yaymukund!). When you merge this PR (which is against your repo), these commits will automatically be included into the main PR (emberjs#1904).

sandraor added a commit that referenced this pull request Jan 9, 2015
Clean up JS, move options to yaml file
@sandraor sandraor merged commit aadd5a3 into sandraor:master Jan 9, 2015
@sandraor
Copy link
Owner

sandraor commented Jan 9, 2015

Thanks @yaymukund and @rwjblue!

@yaymukund yaymukund deleted the meetups-dot-js branch January 9, 2015 10:06
sandraor pushed a commit that referenced this pull request Jan 11, 2015
Integrate column balancer with new meetups.yml structure
sandraor pushed a commit that referenced this pull request Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants