Remove PThread.preallocatedWorkers#10269
Conversation
|
Updated this PR to remove the PThread.preallocatedWorkers concept to simplify the code. |
juj
changed the title
|
Ping on this one. I think this should be easy to land - it simplifies code to remove unnecessary double management of preallocatedWorkers vs unusedWorkers. and the splitting of functions that came with that. It looks perhaps bigger change than it actually is because it moves a large function around. |
| #include <emscripten.h> | ||
| #include <emscripten/threading.h> | ||
| #include <assert.h> | ||
| #include <stdio.h> |
There was a problem hiding this comment.
That is to enable that file to build outside the test harness. The test harness adds implicit stdio.h include somewhere in the added with_report_result concatenation or something like that - the file won't build locally otherwise.
|
ping @belraquib - hoping you can chime in here, to understand the issues @juj raised about #9394 |
…he registration function no longer has a for loop in it that needed the scope, compare with emscripten-core@a936dcb
juj
force-pushed
the
PTHREAD_POOL_DELAY_LOAD
branch
from
9a0da02 to
7766d6f
Compare
|
Any chance this could proceed, looks like @belraquib might not be available to review? |
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
I talked with @belraquib offline, no concerns, lgtm. Nice refactor!
3 participants
When reviewing #10263 I noticed there is a new setting
PTHREAD_POOL_DELAY_LOADthat has popped into existence in #9394.This PR simplifies the implementation of that setting by refactoring not to need a preallocatedWorkers array.