[WasmFS] Allow backends to report errors from flush#17781
Conversation
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
__wasi_fd_sync calls flush in syscalls.cpp, I think that needs to check the return value now? lgtm with that.
| await accessHandle.flush(); | ||
| } catch { | ||
| let err = -{{{ cDefine('EIO') }}}; | ||
| {{{ makeSetValue('errPtr', 0, 'err', 'i32') }}}; |
There was a problem hiding this comment.
I guess this adds errPtr since there wasn't an existing return value to reuse? Just want to make sure I understand the convention.
There was a problem hiding this comment.
Yeah, exactly. That's what was happening before with setSize as well.
|
Oh right, I forgot that I had been adding |
tlively
force-pushed
the
wasmfs-opfs-errors-refactor
branch
from
410395b to
f449ced
Compare
tlively
force-pushed
the
wasmfs-flush-errors
branch
from
d8dd6fc to
5dffb10
Compare
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm, but the off_t change could be in a separate PR?
|
Oops, yeah, I meant to put that in the next PR. |
And catch and report such errors in the OPFS backend to prevent errors from causing the async task to hang and create deadlocks.
tlively
force-pushed
the
wasmfs-flush-errors
branch
from
5dffb10 to
af3d713
Compare
2 participants
And catch and report such errors in the OPFS backend to prevent errors from
causing the async task to hang and create deadlocks.