[WasmFS] Allow move to return specific error codes#17785
Merged
Conversation
Update the return type of `getSize` from `size_t` to `off_t`, which allows for negative error codes. `off_t` is more correct anyway, since in 32-bit mode it is possible for a file size to be greater than the max value of `size_t`. Also update the argument to `getSize` from `size_t` to `off_t` to match. I manually verified that this error handling works with an injected error, but I was not able to create a test that could trigger the error naturally.
It already supporting returning errors via a `bool`, but it is better to be able to return precise errors. Also catch and return errors in the OPFS backend, which did not previously do any error handling for moves. Tested manually via an error injected into the OPFS backend since I don't know a way to get the `move` method on the FileSystemFileHandle to reliably fail in a way that wouldn't cause the syscall implementation to bail out earlier.
This was referenced Sep 2, 2022
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
7 tasks
kripken
approved these changes
Sep 2, 2022
| if (!lockedNewParent.insertMove(newFileName, oldFile)) { | ||
| return -EPERM; | ||
| if (auto err = lockedNewParent.insertMove(newFileName, oldFile)) { | ||
| return err; |
Member
There was a problem hiding this comment.
Maybe in places like this it would be good to assert(err < 0)? (otherwise we are just checking != 0). One other place above too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It already supporting returning errors via a
bool, but it is better to be ableto return precise errors. Also catch and return errors in the OPFS backend,
which did not previously do any error handling for moves.
Tested manually via an error injected into the OPFS backend since I don't know a
way to get the
movemethod on the FileSystemFileHandle to reliably fail in away that wouldn't cause the syscall implementation to bail out earlier.