[mimalloc] Remove no-longer-needed limit on emmalloc alignment#21905
Merged
kripken merged 1 commit intoemscripten-core:mainfrom May 7, 2024
Merged
[mimalloc] Remove no-longer-needed limit on emmalloc alignment#21905kripken merged 1 commit intoemscripten-core:mainfrom
kripken merged 1 commit intoemscripten-core:mainfrom
Conversation
This was referenced May 7, 2024
sbc100
reviewed
May 7, 2024
| // emmalloc has a minimum alignment size. | ||
| #define MIN_EMMALLOC_ALIGN 8 | ||
| #define MAX_EMMALLOC_ALIGN (1024*1024) | ||
| if (try_alignment < MIN_EMMALLOC_ALIGN) { |
Collaborator
There was a problem hiding this comment.
Can try_alignment ever be lower than 8 in mimalloc?
Member
Author
There was a problem hiding this comment.
I think no, since it makes that assumption internally. But we could probably make it do the clamping itself silently, I suppose.
Member
Author
There was a problem hiding this comment.
Oh sorry, you said mimalloc and I read that as emmalloc. I'm not sure. The initial allocations are definitely 4MB-sized, but there may be other incidental allocations in theory in the codebase somewhere.
sbc100
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#20704 removed the maximum alignment limit from emmalloc, so we no longer
need it in the mimalloc port. Without it, we can properly use the 4GB-aligned pages
that mimalloc requests.