Emscripten: Remove no-longer-needed minimum emmalloc alignment#891
Merged
daanx merged 1 commit intomicrosoft:devfrom May 11, 2024
Merged
Emscripten: Remove no-longer-needed minimum emmalloc alignment#891daanx merged 1 commit intomicrosoft:devfrom
daanx merged 1 commit intomicrosoft:devfrom
Conversation
Collaborator
|
Ah, this is great. The previous approach lead to mimalloc always re-requesting with overallocation so this is much better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emscripten-core/emscripten#20704 removed the maximum alignment limit from emmalloc, so we no longer need it in the mimalloc port. Without it, we can properly use the 4GB-aligned pages that mimalloc requests.
(Emscripten-side testing in emscripten-core/emscripten#21905)