[JSPI] Do not automatically wrap async library functions.#24550
Merged
brendandahl merged 4 commits intoemscripten-core:mainfrom Jun 16, 2025
Merged
[JSPI] Do not automatically wrap async library functions.#24550brendandahl merged 4 commits intoemscripten-core:mainfrom
async library functions.#24550brendandahl merged 4 commits intoemscripten-core:mainfrom
Conversation
In a number of places (e.g. `emscripten_async_wget_data`) library functions use an `async` JS functions, but they do not actually want to use JSPI wrappers. Change it so functions must explicitly use `foo__async: true` to enable JSPI wrappers. Fixes emscripten-core#20289
brendandahl
force-pushed
the
jspi-explicit
branch
from
f2ddffa to
e5db73d
Compare
sbc100
approved these changes
Jun 12, 2025
RReverser
reviewed
Jun 12, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 17, 2025
There was a race between emscripten-core#24550 and emscripten-core#24578 resulting in this test failing when it was landed.
sbc100
added a commit
that referenced
this pull request
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a number of places library functions (e.g.
emscripten_async_wget_data) use anasyncJS functions, but they do not actually want to use JSPI wrappers. Change it so functions must explicitly usefoo__async: trueto enable JSPI wrappers.Fixes #20289