[test] Use cflags rather than emcc_args. NFC#24578
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Jun 16, 2025
Merged
[test] Use cflags rather than emcc_args. NFC#24578sbc100 merged 1 commit intoemscripten-core:mainfrom
cflags rather than emcc_args. NFC#24578sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
dschuff
approved these changes
Jun 16, 2025
kripken
approved these changes
Jun 16, 2025
sbc100
force-pushed
the
emcc_args
branch
2 times, most recently
from
744c2ac to
ac98d5b
Compare
This has a few advantages: 1. It paves the way for separating out `ldflags`. 2. It the commonly used name for compiler flags. 3. Its slightly short and easier to type (important only because its repeated in many places)
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 17, 2025
There was a race between emscripten-core#24550 and emscripten-core#24578 resulting in this test failing when it was landed.
sbc100
added a commit
that referenced
this pull request
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has a few advantages:
ldflags.