Adds MQTT backend #117
Adds MQTT backend #117
Conversation
MyPy would complain the method has a "missing return" even though the return is explicit. This seems to happen because of the "async" block. Putting the value that was returned in a variable and returning the variable from outside the "async for" block makes MyPy happy.
MQTT allows for binary messages, deciding for the user that we should convert it to a string would force us to also decide on an encoding. Lets leave this decision to the user.
|
@tomchristie could you please review this? |
| # eclipse-mosquitto does not support configuration via environment variables | ||
| # so it is not possible to use github's service feature to start the broker | ||
| # instead, we start the broker using docker run command and stop it at the end of the job | ||
| - name: "Start MQTT broker" | ||
| run: "docker run -d -p 1883:1883 --name mqtt eclipse-mosquitto:2.0-openssl mosquitto -c /mosquitto-no-auth.conf" |
There was a problem hiding this comment.
Have tried to keep to a strict style within steps of:
name: "Name"
run: scripts/<something>I'd prefer not to break that if possible.
Not sure - should we be including this in the package, or push it out to a repository / code sample that we can link to? Refs #118 |
Okay, I will then close this PR w/o merging. |
Is it worth creating a gist or repo with the MQTT backend, that we link to as an example of a third party implementation? |
|
Not to be merged. Will post it as gist. |
|
Published as gist - https://gist.github.com/alex-oleshkevich/68411a0e7ad24d53afd28c3fa5da468c |
4 participants
Based on work done in https://github.com/encode/broadcaster/pull/32/files
Differences:
Closes #32