This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Adds MQTT backend #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this seems to be outdated. (it does not seem to work with the example code). |
Kludex
reviewed
Aug 20, 2022
MyPy would complain the method has a "missing return" even though the return is explicit. This seems to happen because of the "async" block. Putting the value that was returned in a variable and returning the variable from outside the "async for" block makes MyPy happy.
MQTT allows for binary messages, deciding for the user that we should convert it to a string would force us to also decide on an encoding. Lets leave this decision to the user.
Governa
force-pushed
the
master
branch
4 times, most recently
from
67757cc to
0e48df3
Compare
Author
|
Most of the problems are fixed. What is still missing is a way to create a MQTT service in a GitHub workflow. Inside the |
|
This PR looks like it's real close to being merged and has some nice features |
Closed
Contributor
|
Superseded by #117 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.