Redis Backend Password support

[k1dav]

No description provided.

[hramezani]

Hi @k1dave6412 , Could you please add a test for this patch?

[lovelydinosaur]

Actually I’m pretty okay with changes like this one not adding extra test cases, since they end up being:

Code: “Call this function with this new argument”
Test: “Test that the code called the function with this new argument”

Which doesn’t actually tend to add a lot of value.

[k1dav]

@hramezani I added the simple test

[hramezani]

Actually I’m pretty okay with changes like this one not adding extra test cases, since they end up being:

Code: “Call this function with this new argument”
Test: “Test that the code called the function with this new argument”

Which doesn’t actually tend to add a lot of value.

@tomchristie Thanks for the explanation. I agree with you.

@k1dave6412 Sorry, we don't need the test. Please remove it.

[k1dav]

@hramezani Ok, I remove it

[hramezani]

@k1dave6412 Thanks 👍

[k1dav]

@hramezani When will the PR be merged?

[hramezani]

@k1dave6412 I am not a merger of this project. let's wait for @tomchristie to merge it. I believe he will do that when he has time.

[lbatteau]

@tomchristie can you please review and merge this PR, it's a very simple fix and a huge blocker right now. 🙏

[lbatteau]

If anyone's interested in using Redis directly like me, here's how. https://medium.com/deepdesk/server-sent-events-in-fastapi-using-redis-pub-sub-eba1dbfe8031. Full gist: https://gist.github.com/lbatteau/1bc7ae630d5b7844d58f038085590f97.

[Kludex]

I don't know how to checkout on fork's master branch locally, and I needed to apply black here... So I've created #79 - co-author trailer is added there.

• Closing this in favor of Add password support for Redis backend #79.