This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Implement redis broadcaster using aioredis #23
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
aioredisimplementations were incomplete (#8 and #14). This PR adds support foraioredisand properly handles subscribing and unsubscribing from multiple channels using theaioredis.pubsub.Receiverclass which allows for "multiple producer, single consumer".This PR also fixes a bug with the
MemoryBackendwhere the backend wasn't usable outside of tests. The problem was theasyncio.Queuewas created on__init__instead of onconnectso the wrong event loop was being used.Additionally, a new test is added to verify connected with a redis password works. SSL is also supported but cannot be easily tested with an untrusted CA because of how aioredis handles the
sslparameter. It expects it to betrueorfalse.