Skip to content
This repository was archived by the owner on Aug 19, 2025. It is now read-only.

Conversation

@tizz98
Copy link

@tizz98 tizz98 commented Oct 20, 2020

The existing aioredis implementations were incomplete (#8 and #14). This PR adds support for aioredis and properly handles subscribing and unsubscribing from multiple channels using the aioredis.pubsub.Receiver class which allows for "multiple producer, single consumer".

This PR also fixes a bug with the MemoryBackend where the backend wasn't usable outside of tests. The problem was the asyncio.Queue was created on __init__ instead of on connect so the wrong event loop was being used.

Additionally, a new test is added to verify connected with a redis password works. SSL is also supported but cannot be easily tested with an untrusted CA because of how aioredis handles the ssl parameter. It expects it to be true or false.

@willingc
Copy link

willingc commented Feb 4, 2021

@tomchristie and other maintainers, Thanks for writing this project and for all of the work in the Encode ecosystem. Awesome packages. As this is currently an alpha project, what are the plans, if any, to create an updated release with some of these PRs merged? Thoughts?

@AntonOfTheWoods
Copy link

@tizz98 , from the looks of your repo, it appears you are thinking about creating a broadcaster-notable, given @tomchristie hasn't had the time to answer any of the issues posted here in the last few months. Is there an ETA on that?

@tizz98
Copy link
Author

tizz98 commented Mar 1, 2021

@AntonOfTheWoods you can use it now, it's publised on pypi

@tizz98 tizz98 closed this Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants